intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

WIP: Remove Dependency on Asset catalog to support SPM #189

Closed lkeude96 closed 1 year ago

lkeude96 commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

Goals of this PR :tada:

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

Test Configuration :space_invader:

Things to check on :dart:

croossin commented 4 years ago

This would suffice to get us on SPM? @lkeude96

lkeude96 commented 4 years ago

@croossin i was able to create a branch from this one and got SPM to work 🎉 . this branch 👉 https://github.com/lkeude96/CardParts/tree/spm for testing

Ideally we would be reorganizing a bit and clean up the folder and project structure as well but just adding Package.swift with the dependencies and having it point to the appropriate path got it to work in my test project 😄

In addition, i think the above work could also benefit a similar work mentioned in #10 by @lwdupont

cc #172