intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Jazzy docs #190

Closed xtopolis closed 1 year ago

xtopolis commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

Goals of this PR :tada:

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

Test Configuration :space_invader:

Things to check on :dart:

xtopolis commented 4 years ago

@croossin Need to do a little review, but it's at 100% documentation. A lot of it is redundant property name, or self explanatory property comments. Anything else you'd like done?

xtopolis commented 4 years ago

Ready for any final comments and whether or not I should add in build step or leave it to you.

croossin commented 4 years ago

Would be awesome to have as a build step @xtopolis - but how much of a lift is that?

croossin commented 4 years ago

@xtopolis Is it hard to get this in the build pipeline?

xtopolis commented 4 years ago

I'll be able to look into it by end of week/this weekend, sorry for the delay.

xtopolis commented 4 years ago

@croossin Merge away if ready