Closed rcole34 closed 4 years ago
@rcole34 Looks Good to me , Can we test this change against hosting app's that it wont break the layouts ?
@badrinathvm I did some manual testing and everything seems to be fine, as it still uses the CardParts.theme.cardCellMargins as the default.
@croossin I double checked in hosting apps, and can't see any problems with broken margins. I added the documentation for it under CardsViewController, as that is where the changes are made, and tried to follow the same nested pattern, but let me know if you want me to change anything with that!
Looks great! Will get out in next release.
add field in CardsViewController to allow customization of cardCellMargins
Before you make a Pull Request, read the important guidelines:
Issue Link :link:
Goals of this PR :tada:
How Has This Been Tested :mag:
Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.
Test Configuration :space_invader:
Things to check on :dart: