intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

set new theme in init(coder:) to apply to cardCellMargins in storyboards #200

Closed rcole34 closed 4 years ago

rcole34 commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

Goals of this PR :tada:

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

Test Configuration :space_invader:

Things to check on :dart:

badrinathvm commented 4 years ago

@rcole34 required init?(coder: NSCoder) { CardPartsMintTheme().apply() super.init(coder: coder) } gets called much before than ApplDelegate's func application(_ application: UIApplication, didFinishLaunchingWithOptions method.. This is good.

croossin commented 4 years ago

Looks good.