intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Fixed padding for multiline icon label #204

Closed badrinathvm closed 4 years ago

badrinathvm commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

Goals of this PR :tada:

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

Test Configuration :space_invader:

Things to check on :dart:

rcole34 commented 4 years ago

@croossin I might add to this later this morning; I still see some issues with the text or icon getting pushed off the screen in a couple cases

croossin commented 4 years ago

@rcole34 Okay sounds good - let me know when you want a review

rcole34 commented 4 years ago

@croossin I made a new PR (https://github.com/intuit/CardParts/pull/206) with this change from @badrinathvm and a couple others that seem to work to be able to properly format multiline text. If we can merge that one then this PR can be closed

badrinathvm commented 4 years ago

Closing this PR as these changes have been accommodated as part of https://github.com/intuit/CardParts/pull/206