Custom margins per CardController

[jmjordan]

Is your feature request related to a problem? Please describe. Yes, cards within a CardsViewController must all have the same margin.

Describe the solution you'd like I'd like a way to specify a custom margin for an individual card with a CardsViewController. The main reason is to specify 0 margin for things like transparent cards that need to be the full width of the view.

Describe alternatives you've considered Instead of allowing for any margin, the solution could just be for cards that need to be the full width of the screen.

Additional context I have completed the feature on my fork and am ready to submit a PR if this idea is approved.

[croossin]

This is awesome, @jmjordan. Please open a PR so that we can take a look. Looking forward to reviewing it!

[badrinathvm]

@jmjordan this feature is already present make use of below parameter to set custom margins, by default they are set to default cardPart theme margins.

// allow customization of cardCellMargins for an individual CardsViewController; still default to theme public var cardCellMargins : UIEdgeInsets = CardParts.theme.cardCellMargins

Thanks, Badarinath

On Wed, Dec 4, 2019 at 8:07 AM Chase notifications@github.com wrote:

This is awesome, @jmjordan https://github.com/jmjordan. Please open a PR so that we can take a look. Looking forward to reviewing it!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/intuit/CardParts/issues/207?email_source=notifications&email_token=AALJECY2AXGGGNKMMNRA2RLQW4JXDA5CNFSM4JU7HPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3QR6Q#issuecomment-561449210, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJEC7SJKAXCQ2QDDFWGNDQW4JXDANCNFSM4JU7HPMQ .

[jmjordan]

This is awesome, @jmjordan. Please open a PR so that we can take a look. Looking forward to reviewing it!

@croossin Will do!

_{Sent with GitHawk}

[jmjordan]

@jmjordan this feature is already present make use of below parameter to ...

@badrinathvm I believe that feature only allows having a custom margin for all cards in a CardsViewController. My proposed feature would allow for custom margins on individual cards.

_{Sent with GitHawk}

[badrinathvm]

Yes the parameter which I mentioned does for all the cards not for individual ones. Would be available to see your PR and validate.

Thanks, Badarinath

On Wed, Dec 4, 2019 at 8:30 AM jmjordan notifications@github.com wrote:

@jmjordan https://github.com/jmjordan this feature is already present make use of below parameter to ...

@badrinathvm https://github.com/badrinathvm I believe that feature only allows having a custom margin for all cards in a CardsViewController. My proposed feature would allow for custom margins on individual cards.

Sent with GitHawk http://githawk.com

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/intuit/CardParts/issues/207?email_source=notifications&email_token=AALJEC6EBGUBSHSKGBWLD3LQW4MM3A5CNFSM4JU7HPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3RYAI#issuecomment-561454081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJEC24BN3ENC7U4OTVDW3QW4MM3ANCNFSM4JU7HPMQ .

[croossin]

@badrinathvm As Jordan mentioned, we only have the ability to set for all cards, not individual cards. @jmjordan Please open a PR 😄 thanks.

[badrinathvm]

Yes @croossin , I mentioned Jordan to create a PR to validate.

On Wed, Dec 4, 2019 at 8:34 AM Chase notifications@github.com wrote:

@badrinathvm https://github.com/badrinathvm As Jordan mentioned, we only have the ability to set for all cards, not individual cards. @jmjordan https://github.com/jmjordan Please open a PR 😄 thanks.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/intuit/CardParts/issues/207?email_source=notifications&email_token=AALJEC4G6QUB4LSEGCL3IALQW4M5FA5CNFSM4JU7HPM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3SBAI#issuecomment-561455233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJEC4ENSWXGPLF7OQRCHTQW4M5FANCNFSM4JU7HPMQ .

[jmjordan]

PR: https://github.com/intuit/CardParts/pull/208

[croossin]

Completed in PR #208 and Version 2.22.0