Feature/custom margins - Githubissues

jmjordan commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

Is this a bug fix or a feature?
Does it break any existing functionality?

Goals of this PR :tada:

Why is the change important?
What does this fix?
How far has it been tested?

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

User Interface Testing
Application Testing

Test Configuration :space_invader:

Xcode version:
Device/Simulator
iOS version || MacOSX version

Things to check on :dart:

[ ] My Pull Request code follows the coding standards and styles of the project
[ ] I have worked on unit tests and reviewed my code to the best of my ability
[ ] I have used comments to make other coders understand my code better
[ ] My changes are good to go without any warnings
[ ] I have added unit tests both for the happy and sad path
[ ] All of my unit tests pass successfully before pushing the PR
[ ] I have made sure all dependent downstream changes impacted by my PR are working

Manual testing was conducted on a few example cards. I created a new example card, but did not include it in my PR. I did not use UIEdgeInsets as the custom margin in my protocol since the layout simply centers the card within the collection and does not distinguish between left and right margins.

badrinathvm commented 4 years ago

@jmjordan Can you add a example in Example project to illustrate custom margins usage ?

croossin commented 4 years ago

Thanks @jmjordan - I will merge and get a release out before the weekend! Thanks.

P.S. Feel free to mention on any other features you would like to see from CardParts.

intuit / CardParts