intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Darkmode #216

Open croossin opened 4 years ago

croossin commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link: #184

Goals of this PR :tada:

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

Test Configuration :space_invader:

Things to check on :dart:

lwdupont commented 4 years ago

Yes!! :)

tys-adventure commented 4 years ago

Is there anything holding this back from being merged? 😯

croossin commented 4 years ago

@TyJPhillips Just fixing up some last second stuff

croossin commented 4 years ago

Just trying to get CardPartAttributedTextView working nicely with dark mode Simulator Screen Shot - iPhone 11 Pro Max - 2020-01-21 at 07 00 30

tys-adventure commented 4 years ago

Just trying to get CardPartAttributedTextView working nicely with dark mode Simulator Screen Shot - iPhone 11 Pro Max - 2020-01-21 at 07 00 30

Looking good thus far sir! Looking forward to the merge, and keep up the good work!

croossin commented 4 years ago

I believe we are good to go now!! @badrinathvm Feel free to take another look πŸ‘

croossin commented 4 years ago

And a huge shoutout to @lkeude96 for all of his contributions !!!!!

badrinathvm commented 4 years ago

@croossin Looks Good to me.

ghost commented 4 years ago

Any plans to merge this?

bevbomb commented 4 years ago

Any plans to merge this?