intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Adding dynamic support of height in CardPartPagedView #244

Closed rattandeep1998 closed 4 years ago

rattandeep1998 commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

This is an additional capability in CardPartPagedView to dynamically update the height of the view after it has already been instantiated. And it will not break any existing capability.

Goals of this PR :tada:

We are using CardParts in Mint and specifically for bills overview card we are using CardPartPagedView component [which is similar to pageViewController functionality i.e. provides the ability to have multiple scrollable views in our case horizontal]. We have a requirement of dynamically changing the height of this view when state of this card changes from empty state to data state. [ An empty state is when a user does not have any bills attached or the bills are currently been fetched. Data state is when user’s bills have been fetched and ready for display ]. When the bills are in empty state lets say the height of the bills overview should be 400 and when the bills have been fetched we have to resize the bills overview card to 350.

How Has This Been Tested :mag:

We have tested this PR with Mint app and the changes works fine everywhere.

Things to check on :dart: