Closed czuria1 closed 4 years ago
Great clean fix @czuria1! We encountered this issue with CardsViewControllers not readjusting their margins when presented in iPad form sheet modals. I believe this should also fix #242 and possibly #221 as well
@czuria1 Like the usage of distinctUntilChanged()
the operator ignores duplicate consecutive emissions.
Looks good to me.
Also on side check Can we make sure this doesn't affect any of the existing things on iPhone ?
@badrinathvm Right, it should not affect any current implementation on an iPhone.
Before you make a Pull Request, read the important guidelines:
Issue Link :link:
Goals of this PR :tada:
CardsViewController
should reflect the latest size in the layout, specifically recalculating the sizing of the cells of the flow layout if thecardCellWidth
changes.cardCellWidth
changes such as when aCardsViewController
is presented as a formSheet on an iPad.How Has This Been Tested :mag:
Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.
Test Configuration :space_invader:
Things to check on :dart: