intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Fix wrong layout on iPad modal presentation when the view controller frame is changed #254

Closed czuria1 closed 3 years ago

czuria1 commented 3 years ago

Before you make a Pull Request, read the important guidelines:

Issue Link :link:

Goals of this PR :tada:

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

Test Configuration :space_invader:

Things to check on :dart:

rcole34 commented 3 years ago

Great clean fix @czuria1! We encountered this issue with CardsViewControllers not readjusting their margins when presented in iPad form sheet modals. I believe this should also fix #242 and possibly #221 as well

badrinathvm commented 3 years ago

@czuria1 Like the usage of distinctUntilChanged() the operator ignores duplicate consecutive emissions. Looks good to me. Also on side check Can we make sure this doesn't affect any of the existing things on iPhone ?

czuria1 commented 3 years ago

@badrinathvm Right, it should not affect any current implementation on an iPhone.