intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 224 forks source link

Added SPM support #264

Open calebkleveter opened 4 years ago

calebkleveter commented 4 years ago

Issue Link https://github.com/intuit/CardParts/issues/172

Closes https://github.com/intuit/CardParts/issues/172

Goals of this PR :tada:

Adds support for the Swift Package Manager, as an alternative to CocoaPods.

How Has This Been Tested :mag:

Adds a single test CardPartImageViewTests.testAssetResources to check that resources are properly loaded in an SPM environment.

Test Configuration :space_invader:

Things to check on :dart:

calebkleveter commented 4 years ago

I am getting this warning on all the dependency modules (RxSwift, RxRelay, RxCocoaRuntime, RxCocoa, Differentiator, and RxDataSource).

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

I don't know if there is a good way to fix this, but I am looking.

calebkleveter commented 4 years ago

The warnings are apparently caused by Xcode 12 dropping support for iOS 8. This means that the warnings that this PR introduces are caused by the dependencies, not the package itself. Separate PRs would have to be submitted to the dependency repos to increase their minimum iOS version to 9.