Implementation of CardPart Video View

badrinathvm commented 4 years ago

Before you make a Pull Request, read the important guidelines:

Implementation of CardPartVideoView.

Video_iOS

Issue Link :link:

New Feature
Does it break any existing functionality? - None

Goals of this PR :tada:

Why is the change important? - Addition of new component to CardParts for displaying Videos
What does this fix?
How far has it been tested? - Unit / UI Tested

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

User Interface Testing : YES
Application Testing: YES

Test Configuration :space_invader:

Xcode version: 12.0
Device/Simulator: 11.0
iOS version || MacOSX version: Catalina - 10.15.7

Things to check on :dart:

[ ] My Pull Request code follows the coding standards and styles of the project
[ ] I have worked on unit tests and reviewed my code to the best of my ability
[ ] I have used comments to make other coders understand my code better
[ ] My changes are good to go without any warnings
[ ] I have added unit tests both for the happy and sad path
[ ] All of my unit tests pass successfully before pushing the PR
[ ] I have made sure all dependent downstream changes impacted by my PR are working

rcole34 commented 4 years ago

@croossin @bharathmurs this seems to be working fine for Badari, but I wasn't sure if this is the "CardParts" way of adding a subview from another controller? I was thinking he might need to set the viewController property of the CardPartsVideoView to get this snippet from setupCardParts to run, but it seems to work without that also https://github.com/intuit/CardParts/blob/master/CardParts/src/Classes/CardPartsViewController.swift#L85:L88

badrinathvm commented 4 years ago

@rcole34 self.viewContoller.addChild(.. https://github.com/intuit/CardParts/pull/265/commits/c2c0e5cab62407d843b4f0dfb8a46d3ac6bc6930 from CardPartView is being removed in CardPartVideoView, the above comment might is not valid anymore.

croossin commented 4 years ago

Just curious does this support picture-in-picture out of the box

intuit / CardParts