search

intuit / CardParts

A reactive, card-based UI framework built on UIKit for iOS developers.
Other
2.52k stars 225 forks source link

Add an method to modify distribution #76

Closed Helen-Xu closed 6 years ago

Helen-Xu commented 6 years ago

The current distribution mode is set to equalSpacing, which is nice for some cards. However, it's preventing me from placing a cardPart at a certain position. Is it possible to add an function like modifyDistribution to switch distribution to .fill, so that cardParts will be placed according to margins?

lwdupont commented 6 years ago

@croossin I asked Helen to post this, she's working on our Turbo team right now. :)

bharathmurs commented 6 years ago

@PenguinRAD What does it mean by placed according to margins? Current setupCardParts does place the cardParts as per the margins. Can you give an example with an image?

bharathmurs commented 6 years ago

After talking to @PenguinRAD, we will take a look at the implementation of CardPartCollectionViewCardPartsCell so that the spacing b/w the elements adhere to the margins set.

lwdupont commented 6 years ago

Feel free to ask her to do it too :)

croossin commented 6 years ago

@bharathmurs @Helen-Xu Was this completed by #77 ?

lwdupont commented 6 years ago

Yup.

croossin commented 6 years ago

Closing since completed by #77