intuit / LD-React-Components

Semantic component helpers to support LaunchDarkly feature flags in your React app.
MIT License
24 stars 35 forks source link

Add test summary to circleci #61

Closed tekgal closed 5 years ago

tekgal commented 5 years ago

What Changed

fixes #58 updated package.json "test" command definition to create test summary in junit format and also moves the junit.xml output file in desired path as specified in the circleci config.yaml

Why

Circleci understands junit output format. Todo:

tekgal commented 5 years ago

@poorpaddy do you know why the "test" "lint" and "build" are stuck in pending state for the PR above?

tekgal commented 5 years ago

@poorpaddy this is how the test summary appears. image

tekgal commented 5 years ago

@all-contributors please add tekgal for infra

allcontributors[bot] commented 5 years ago

@tekgal

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

poorpaddy commented 5 years ago

@all-contributors please add @tekgal for infra

allcontributors[bot] commented 5 years ago

@poorpaddy

I've put up a pull request to add @tekgal! :tada:

poorpaddy commented 5 years ago

@poorpaddy do you know why the "test" "lint" and "build" are stuck in pending state for the PR above?

That I am not sure. I haven't figured out why as I do not receive any errors. When I look at this PR though after the fact they seem to all pass. The only failure is the release which is fine because we don't want release to occur on a PR.