search

intuit / LD-React-Components

Semantic component helpers to support LaunchDarkly feature flags in your React app.
MIT License
24 stars 35 forks source link

Follow-up to pull#59 (saving CircleCI test summaries) #62

Closed funkadelic closed 5 years ago

funkadelic commented 5 years ago

What Changed

fixes #58

confirmed working with the following job: https://app.circleci.com/jobs/github/funkadelic/LD-React-Components/67

Why

Todo:

poorpaddy commented 5 years ago

@all-contributors please add @funkadelic for infra

allcontributors[bot] commented 5 years ago

@poorpaddy

We had trouble processing your request. Please try again later.

poorpaddy commented 5 years ago

@all-contributors please add @funkadelic for infra

allcontributors[bot] commented 5 years ago

@poorpaddy

I've put up a pull request to add @funkadelic! :tada:

allcontributors[bot] commented 5 years ago

@poorpaddy

I've updated the pull request to add @funkadelic! :tada:

poorpaddy commented 5 years ago

@funkadelic I'm not actually seeing the test summaries being produced from this PR. I am however seeing it on the previous PR. Perhaps it is not a loss though since value is added with the .gitignore and clean up process added. If you revise this to just be those two changes I'll merge it as it will no longer be duplicative.

funkadelic commented 5 years ago

@poorpaddy yeah, i think the difference between my PR and the other one was that all changes were in .circleci/config.yml whereas the other one was in package.json. I had to merge down to master in my fork to get CircleCI to actually apply my .circleci/config.yml changes, which I think is why it didn't produce anything in this PR. Six of one, half a dozen of the other 😄