search

intuit / LD-React-Components

Semantic component helpers to support LaunchDarkly feature flags in your React app.
MIT License
24 stars 35 forks source link

Update NPM Dependencies #85

Closed poorpaddy closed 4 years ago

poorpaddy commented 4 years ago

Is your feature request related to a problem? Please describe.

Some of the dependencies are out of date and it is crucial for the maintenance of this package to keep up with React and TypeScript. This may mean updating code for compatibility with newer standards.

An easy way to do this is to setup npm-check-updates via yarn global add npm-check-updates. This will provide a list of all dependencies needing to be updated and wether they are major breaking changes or not.

Example in screenshot below: Screen Shot 2020-09-10 at 12 37 43 PM

faulker commented 4 years ago

Updated the storybook dependence and updated the storybook configs/stories to work with the update to v6 https://github.com/intuit/LD-React-Components/pull/88

nsinghal12 commented 4 years ago

@poorpaddy Is this done?

poorpaddy commented 4 years ago

@nsinghal12 no it's not. There was a PR for it but it didn't resolve breaking changes that also require code changes and therefore it was rejected.

poorpaddy commented 4 years ago

Storybook dependency has been resolved in #88

ksuperman commented 4 years ago

@poorpaddy can i take this up as part of the hacktober if no one is working on this ?

poorpaddy commented 4 years ago

Hacktoberfest has now concluded and therefore closing this issue specific to October 2020.