intuit / LD-React-Components

Semantic component helpers to support LaunchDarkly feature flags in your React app.

MIT License

24 stars 35 forks source link

chore: added commitlint support #89

Closed skodamarthi closed 4 years ago

skodamarthi commented 4 years ago

What Changed

Added Commitlint Also added husky pre-commit hook that triggers commitlint every time a contributor tries to commit. This ensures that the correct commit conventions are followed as listed here https://www.conventionalcommits.org/en/v1.0.0/

Why

Fix for https://github.com/intuit/LD-React-Components/issues/87 Todo:

[ ] Add tests
[ ] Add docs
[ ] Add yourself to contributors (run yarn contributors:add))

skodamarthi commented 4 years ago

@poorpaddy Can you please review?

skodamarthi commented 4 years ago

@poorpaddy Addressed the conflicts. Can you please check and merge the PR if changes are ok? Thanks!

poorpaddy commented 4 years ago

@all-contributors please add @skodamarthi for tests

allcontributors[bot] commented 4 years ago

@poorpaddy

I've put up a pull request to add @skodamarthi! :tada:

skodamarthi commented 4 years ago

Thank you @poorpaddy Can you please add hacktoberfest-accepted label as well? Thank you!