search

intuit / QuickBooks-V3-DotNET-SDK

.Net SDK for QuickBooks REST API v3 services
Apache License 2.0
107 stars 140 forks source link

Use version range for Serilog dependencies #258

Open nbarbettini opened 2 years ago

nbarbettini commented 2 years ago

I've been bitten twice by this: https://github.com/intuit/QuickBooks-V3-DotNET-SDK/issues/225#issuecomment-1209966318 I agree with the suggestion in #221 that removing references to Serilog entirely is a good direction for a library project to take.

In the meantime, some of the developer pain could be avoided by declaring a version range in the Nuget package.

Instead of

<PackageReference Include = "Serilog.Sinks.Console" Version="3.1.1" /> <!-- Supports any version 3.1.1 or higher -->

I suggest

<PackageReference Include = "Serilog.Sinks.Console" Version="[3.1.*,4)" /> <!-- Supports 3.1.0 or higher, but not 4.x -->
smasherprog commented 1 year ago

Having all of the serilog references is such a poor design choice. please correct this.