Open pavel-dushkov-am opened 2 years ago
HI Pavel, Thanks for the PR. I have moved to a different team and SDK ownership will be transferred. CLosing off the pending PRs. Looks like with this change, is this the final fix for the issue you faced as I see the PR is still draft. Can you make the PR ready and I will review n merge. Looks like our SDKs never handled the 200 with fault scenarios well ans this behavior from our APIs is recent it seems.
@nimisha84, my approach for fix is next
IterateFaultAndPrepareException
method from Batch
to extension method for reusing it in DataService
Fault
with errors, iterate them and throw exceptionAttachable
nor Fault
with errors, throw InvalidServiceRequestException
with raw response, to give developers the opportunity to analyze what happened. (type of this exception can be changed - maybe InvalidServiceRequestException
is not suitable for such cases).At first I wanted to extract IterateFaultAndPrepareException
from FaultHandler
, but it's not static there, so I decided not to risk
Fix for https://github.com/intuit/QuickBooks-V3-DotNET-SDK/issues/259