intuit / QuickBooks-V3-DotNET-SDK

.Net SDK for QuickBooks REST API v3 services
Apache License 2.0
107 stars 140 forks source link

Add handling of 200 OK response with Fault for attachment uploading #260

Open pavel-dushkov-am opened 2 years ago

pavel-dushkov-am commented 2 years ago

Fix for https://github.com/intuit/QuickBooks-V3-DotNET-SDK/issues/259

nimisha84 commented 1 year ago

HI Pavel, Thanks for the PR. I have moved to a different team and SDK ownership will be transferred. CLosing off the pending PRs. Looks like with this change, is this the final fix for the issue you faced as I see the PR is still draft. Can you make the PR ready and I will review n merge. Looks like our SDKs never handled the 200 with fault scenarios well ans this behavior from our APIs is recent it seems.

pavel-dushkov-am commented 1 year ago

@nimisha84, my approach for fix is next

At first I wanted to extract IterateFaultAndPrepareException from FaultHandler, but it's not static there, so I decided not to risk