search

intuit / QuickBooks-V3-DotNET-SDK

.Net SDK for QuickBooks REST API v3 services
Apache License 2.0
107 stars 140 forks source link

Added 'groupby' parameter to ReportService #262

Closed clement911 closed 1 year ago

clement911 commented 2 years ago

Note that there is an existing parameter group_by but we're adding groupby without the _.

We're not sure if the existing group_by parameter was just a typo and should be removed.

groupby is definitely a valid parameter. As a proof, if you try to get the report named "TransactionDetailByAccount" and pass a "group_by" parameter with a value of "none", you will get an error. If you pass "groupby" instead, it will work.

clement911 commented 2 years ago

hi @nimisha84 ,do you need anything else from me before you can merge this?

clement911 commented 1 year ago

@nimisha84 could you review this PR please?

nimisha84 commented 1 year ago

Thanks, Looks like a bug to me. But this fix would be a good workaround without breaking the existing devs.