intuit / QuickBooks-V3-DotNET-SDK

.Net SDK for QuickBooks REST API v3 services
Apache License 2.0
107 stars 140 forks source link

Adopt Microsoft.Extensions.* #286

Open dahlbyk opened 1 year ago

dahlbyk commented 1 year ago

Pullling out of #221 for discussion:

All things being equal, I would probably target version 2.1.x for these dependencies due to support on .NET Framework.

dahlbyk commented 1 year ago

https://learn.microsoft.com/en-us/dotnet/core/extensions/logging has a good overview of Microsoft.Extensions.Logging, including the intent of each log level. Aside from Serilog, a pain point with the current logging is it's almost all at the same level. Would help to promote some things to warnings, have basic request URL logged as info, and make sure everything with sensitive data (auth codes/headers, request/response bodies) uses Trace (for example).

I think the right approach is to give IppConfiguration an ILoggerFactory so different components can get loggers with an appropriate category for filtering.

dahlbyk commented 1 year ago

Haven't looked at OAuth yet, but for the main package it seems like we'd want something like services.AddQuickBooksOnlineClient() that registers:

Any other thoughts from your experiments, @MatthewSteeples?

drusellers commented 7 months ago

@dahlbyk speaks the truth! I would love to see some of this integrated.