search

intuit / QuickBooks-V3-Java-SDK

Java SDK for QuickBooks REST API v3 services
Apache License 2.0
66 stars 144 forks source link

Split package com.intuit.ipp.core between java-devkit and java-data #121

Open plcarmel opened 4 years ago

plcarmel commented 4 years ago

It makes it impossible to include both of those maven dependencies directly (i.e.e without some form of repackaging) in a Java 9 modules.

diana-derose commented 4 years ago

hey @plcarmel - I have added a story in our backlog to address this. Here's the internal jira id IDG-3475 for reference. We'll try to scope this work in our upcoming sprints. If you would like to contribute a fix for this, please send across a PR.

rachanamamillapalli commented 4 years ago

Hi @fjolin-intuit, I would like to work on this

rachanamamillapalli commented 4 years ago

@diana-derose / @plcarmel Is this still needed or some work is already going one?

plcarmel commented 4 years ago

@rachanamamillapalli, that would be appreciated.

fjolin-intuit commented 4 years ago

@rachanamamillapalli This is still needed - your contribution is welcomed :)

ashking94 commented 3 years ago

@plcarmel @rachanamamillapalli is this being looked upon? I wanted to understand the issue and take a stab onto fixing this over the weekend.

plcarmel commented 3 years ago

@ashking94, not by me.

rachanamamillapalli commented 3 years ago

@fjolin-intuit @plcarmel @diana-derose Could you take a look at the PR linked to this issue.

fjolin-intuit commented 3 years ago

@rachanamamillapalli I spent some time looking at this - it would introduce some breaking changes which is ok as long as we version the release and put communication out beforehand. Were you able to test this PR against a sample? I tried this and couldn't get the dependencies to work out - I think it might be because the all project that was introduce is a generator pom instead of creating jars. I wasn't able to figure out how to import ipp-v3-java-all into my project. If you could try this in a sample to show how converting is done - we could create better communication around this change and I could bump up a major version change.

rachanamamillapalli commented 3 years ago

@fjolin-intuit I haven't tested it on sample yet. Will try importing and update once I make any progress.

othenos commented 3 years ago

Is there any workaround for this problem? module XXX reads package com.intuit.ipp.core from both ipp.v3.java.devkit and ipp.v3.java.data I cannot seem to find an answer anywhere. There must be some developers who have moved beyond Java 8 and circumvented this somehow.