Illegal characters inside response will cause fatal error in XmlObjectSerializer.php

[siimtalts]

When fetching a payments via API the response has illegal characters:

<creditcardpayment>
    <creditchargeinfo>
        <number>xxxxxxxxxxxx8005</number>
        <nameonacct>Lets Panic</nameonacct>
        <ccexpirymonth>12</ccexpirymonth>
        <ccexpiryyear>2017</ccexpiryyear>
        <postalcode>9999</postalcode>
    </creditchargeinfo>
</creditcardpayment>

Notice the weird symbol in nameonacct. This is illegal characer and results in an fatal error thrown by simplexml_load_string in XmlObjectSerializer. I know this is because legacy data, as I wasn't able to reproduce this with new entries in QB, but it needs to be fixed, because we are dealing with importing older datasets with this SDK.

Solution: implement XML sanitization. An example code snippet can be found from here: https://www.ryadel.com/en/php-skip-invalid-characters-utf-8-xml-file-string/

[bsivalingam]

@siimtalts Please send in a PR if you are interested to fix it, I will have it reviewed and merged.

[abisalehalliprasan]

Opening up SDK for hacktoberfest contributions.

Hacktoberfest is underway right now and we would love for you to contribute 🚀 . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

[rum1887]

is the issue open?