search

intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/
Apache License 2.0
241 stars 243 forks source link

Renaming file for IPPWrapper class to make it PSR4 and Composer 2 compatible #375

Closed jaydiablo closed 3 years ago

jaydiablo commented 3 years ago

This fixes #341 and #329 and should replace the fix in #361 as that change erroneously changes the namespace of the IPPWrapper class, but that's not necessary for this fix as all of the IPP SDK classes live in the QuickBooksOnline\API namespace as that's how they're autoloaded in composer.json.

I didn't see any cases where this class was being explicitly required by filename, but anybody doing that (and not using composer's autoloading) might have an issue loading this class.

A dummy IPP.php file that just requires IPPWrapper.php could be put in place to combat this situation, if that seems reasonable.

grimabe commented 3 years ago

Composer 2 has been out for a while know, it would be nice to see this in a next release. Thanks

devguar commented 3 years ago

This is still not fixed. Deprecation Notice: Class QuickBooksOnline\API\Data\IPPWrapper located in ./vendor/quickbooks/v3-php-sdk/src/Data/IPP.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in [...]/Autoload/ClassMapGenerator.php:201

(on version 5.4.7)

jaydiablo commented 3 years ago

@devguar it looks like the fix was included in the 6.0.0 release: https://github.com/intuit/QuickBooks-V3-PHP-SDK/releases/tag/6.0.0