Constant names should comply with a naming convention - Githubissues

intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/

Apache License 2.0

246 stars 246 forks source link

Constant names should comply with a naming convention #407

Open ArchTaqi opened 3 years ago

ArchTaqi commented 3 years ago

As PSR2 Coding Conventions;

Constants names should comply with regular expression ^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Utility/UtilityConstants.php#L12

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Utility/UtilityConstants.php#L17

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Utility/UtilityConstants.php#L22

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/DataService/IntuitResponseStatus.php#L16

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/DataService/IntuitResponseStatus.php#L21

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Diagnostics/TraceLevel.php#L13

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Diagnostics/TraceLevel.php#L19

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Diagnostics/TraceLevel.php#L25

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Diagnostics/TraceLevel.php#L31

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/73c395d7243fa4dc63027a94cda20180c8b3b5cb/src/Diagnostics/TraceLevel.php#L37