intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/
Apache License 2.0
245 stars 246 forks source link

Issue with Server Fault Responses and 200 Errors #413

Open mmoreno509 opened 3 years ago

mmoreno509 commented 3 years ago

So we're having an issue with our application that it is not always succeeding in transferring invoices to quickbooks, upon further inspection I found this line of code:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/a4139a9cc439a5c03edec070d56344b1dc82056f/src/Core/Http/Serialization/XmlObjectSerializer.php#L124

The API documentation here mentions Faults that could be included in a 200 ok response: https://developer.intuit.com/app/developer/qbo/docs/develop/troubleshooting/error-codes

our problem is that we are getting a 200 ok, and assuming that everything in quickbooks went as expected, but it doesn't.

There are Fault errors that are not being reported through the SDK as a result of this line right here. is there anyway other than forking and removing that line that we could capture those server fault error messages?

javabudd commented 3 years ago

can anyone from the intuit team even respond to this?