search

intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/
Apache License 2.0
243 stars 246 forks source link

"com\intuit\..." prefixes on class types #425

Open themightychris opened 3 years ago

themightychris commented 3 years ago

What's with all the properties being declared with types like com\intuit\schema\finance\v3\IPPReferenceType:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/Data/IPPSalesTransaction.php#L71

When the namespace for IPPReferenceType is QuickBooksOnline\API\Data:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/Data/IPPReferenceType.php

This makes it impossible for a project setting these properties to pass static analysis without tons of exceptions

kkmuffme commented 2 years ago

This is incredibly annoying, please merge the PR I provided.

kkmuffme commented 1 year ago

Fyi: the reason it's there is bc Bind.php could use it to map it against the XML schema, but that's not implemented anyway

kkmuffme commented 1 year ago

Btw this won't be fixed ever, as they use it as a namespace prefix and the SDK is super buggy atm. See https://github.com/intuit/QuickBooks-V3-PHP-SDK/issues/505