intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/
Apache License 2.0
246 stars 246 forks source link

FindAll method - pagenumber is actually start position #473

Open LiamAshdown opened 1 year ago

LiamAshdown commented 1 year ago
/**
     * Retrieves all entities by name
     *
     * @param string $entityName
     * @param int $pageNumber
     * @param int $pageSize
     * @return array Returns an array of entities of specified type.
     */
    public function FindAll($entityName, $pageNumber = 0, $pageSize = 500)

I was expecting the page number to be my nth set of pages based on the page size however it looks like this then formats a query

$httpsPostBody = "select * from $entityName startPosition $pageNumber maxResults $pageSize";

so actually $pageNumber is startposition and maxresults

gazever commented 1 year ago

I have also noticed this - we just use the query method instead