intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/
Apache License 2.0
241 stars 240 forks source link

Update LoggerBase.php #481

Closed webkulabhi closed 1 year ago

webkulabhi commented 1 year ago

In file vendor/quickbooks/v3-php-sdk/src/Core/Configuration/LocalConfigReader.php using undefined following property /**

public static function setupLogger($ippConfig, $ServiceRequestLoggingLocation, $EnableRequestResponseLogging) { $ippConfig->Logger = new Logger(); $ippConfig->Logger->RequestLog->ServiceRequestLoggingLocation = $ServiceRequestLoggingLocation; $ippConfig->Logger->RequestLog->EnableRequestResponseLogging = $EnableRequestResponseLogging; }

webkulabhi commented 1 year ago

issues : https://github.com/intuit/QuickBooks-V3-PHP-SDK/issues/480

algirdasbr commented 1 year ago

This still looks like a valuable improvement. At least it fixes PHP 8.2 deprecation notices about dynamic properties.

sujitharamadass commented 1 year ago

Please try with the latest version 6.1.2