search

intuit / QuickBooks-V3-PHP-SDK

Official PHP SDK for QuickBooks REST API v3.0: https://developer.intuit.com/
Apache License 2.0
241 stars 240 forks source link

Incorrect Transaction List report parameter names in ReportService.php #489

Closed bch36 closed 1 year ago

bch36 commented 1 year ago

The parameter name "both_amount" on line 1236 should be "bothamount".

array_push($uriParameterList, array("both_amount", $this->getBothAmount()));

should be:

array_push($uriParameterList, array("bothamount", $this->getBothAmount()));

Similarly, the parameter name "doc_num" on line 1242 of ReportService.php should actually be "docnum". 

array_push($uriParameterList, array("doc_num", $this->getDocNum()));

should be:

array_push($uriParameterList, array("docnum", $this->getDocNum()));

As is, they are silently ignored when running a Transaction List report.

sujitharamadass commented 1 year ago

Fixed in version 6.1.2