Update ScriptProcessor Bean to @RequestScoped

intuit / Tank

Tank is a downloadable application that can be used to load test websites

Eclipse Public License 1.0

84 stars 61 forks source link

Update ScriptProcessor Bean to @RequestScoped #308

Closed kevin-mcgoldrick closed 6 months ago

kevin-mcgoldrick commented 7 months ago

Update ScriptProcessor Bean to @RequestScoped

Please make sure these check boxes are checked before submitting

[x] Squashed Commits
[x] All Tests Passed - mvn clean test -P default

PR review process

Requires one +1 from a reviewer
Repository owners will merge your PR once it is approved.

kevin-mcgoldrick commented 7 months ago

Excellent find. That must be why it's Dependent. I'll try the other approach in QA.

Validated script upload via API no longer spiking memory usage, but ran into issues uploading scripts via Tank UI with ScriptServiceUtil:389 - Error unmarshalling script: null error

Zakaria-Kofiro commented 6 months ago

Validated script upload via API no longer spiking memory usage, but ran into issues uploading scripts via Tank UI with ScriptServiceUtil:389 - Error unmarshalling script: null error

Change working as intended, this error is unrelated to the change, arising from re-uploading a specific unfiltered script. It also throws the same error when uploading on master branch.