os.system replaced with subprocess module

intuit / Trapheus

This tool automates restoration of RDS database instances from snapshots into any dev, staging or production environments. It supports individual RDS Snapshot as well as cluster snapshot restore operations.

https://intuit.github.io/Trapheus/

MIT License

106 stars 53 forks source link

os.system replaced with subprocess module #151

Closed Madhura-saw closed 1 year ago

Madhura-saw commented 1 year ago

Description

Substituted the previous use of os.system with subprocess.run, and implementing try and except for error handling.

Relevant Issues : #95
Type of change :
- [ ] New feature
- [x] Bug fix for existing feature
- [ ] Code quality improvement
- [ ] Addition or Improvement of tests
- [ ] Addition or Improvement of documentation

Output

stationeros commented 1 year ago

@Madhura-saw This looks fine, can we add the ouput of a successful run of install and you should be good to go

Madhura-saw commented 1 year ago

@Madhura-saw This looks fine, can we add the ouput of a successful run of install and you should be good to go

So for this I need to setup Trapheus right? and where do I add the output?

stationeros commented 1 year ago

just try step 3 and 4 from here https://github.com/intuit/Trapheus#setup and add the output as part of the PR itself

Madhura-saw commented 1 year ago

just try step 3 and 4 from here https://github.com/intuit/Trapheus#setup and add the output as part of the PR itself

okay

Madhura-saw commented 1 year ago

I have added the output, the install file is running