intuit / accessibility-snippets

VSCode Snippets created to help developers write accessible code.

MIT License

102 stars 37 forks source link

Added MeterAria #62

Closed bolu-tife closed 3 years ago

bolu-tife commented 3 years ago

What Changed

Added ARIA meter role in react-snippets.code-snippets

Why

Solution to #58

Todo:

[ ] Add Semantic Version Label
[x] Add tests/Tested on local machine
[x] Add docs

bolu-tife commented 3 years ago

What Changed

Updated README.md with ARIA meter role

Why

Solution to #58

kendallgassner commented 3 years ago

Minor comment! We have updated the readme to be formatted as a table! If you can update you pr + edit in the readme to align with the change that would be amazing 🙏 thank you!!

bolu-tife commented 3 years ago

I have updated the README.md to accommodate the new format in #64.

kendallgassner commented 3 years ago

I am not seeing the meter aria in the readme .. It looks like you might have forgotten to add it

kendallgassner commented 3 years ago

whoops. I see the other pr now