intuit / accessibility-snippets

VSCode Snippets created to help developers write accessible code.
MIT License
102 stars 37 forks source link

chore(run-tests): run tests in circle ci #65

Closed DianaTdr closed 3 years ago

DianaTdr commented 3 years ago

What Changed

Adds an extra step to run tests in circle ci

Why

Requested here https://github.com/intuit/accessibility-snippets/issues/47 Todo:

DianaTdr commented 3 years ago

@kendallgassner Please review when you got some time. I don't have access to add circle ci as part of the prs, but this should add the yarn test as part of the master circle ci at least. Also, i noticed that the yarn test command was failing because the snippets did not have json format as it was merged here https://github.com/intuit/accessibility-snippets/pull/44 (maybe something got updated later and reverted the changes). Anyway, i renamed it back so now yarn test is passing

kendallgassner commented 3 years ago

I renamed them back to the old file name. I wasn't sure why we changed the file type but the files are actually referenced in the package.json so we will need to update the name there as well

DianaTdr commented 3 years ago

@kendallgassner I've updated the package.json file names and re-tested that yarn test works

DianaTdr commented 3 years ago

Hi @kendallgassner could you please add a “hacktoberfest-accepted” label to this pr? Would gladly appreciate it :)