search

intuit / benten

Chatbot Development Framework (with Slack integration for Jira and Jenkins)
MIT License
134 stars 57 forks source link

Added Hackernews Bolt #37

Closed jakeleveroni closed 4 years ago

jakeleveroni commented 4 years ago

fixes #23 implemented the hacker news bolt with a decent amount of functionality based on its very limited API.

jakeleveroni commented 4 years ago

The changes to the following files were unintentional but im not sure how or why they were changed in the first place:

~BenetenStarterApplication.java~ ~BenetenApplication.java~ ~HtmlToImageConverter.java~ ~AiException.java~ ~ImageGenerationExcaption.java~ ~AiProperties.java~ ~BentenProxyConfig.java~ ~SlackProperties.java~ ~NlpClient.java~ ~DialogFlowClient.java~ ~DialogFlowClientTest.java~

Im thinking maybe maven commands updated the files when i didnt want them to. @DivakarUngatla do you have any idea on how i can revert these other than manually?

UPDATE: all unnecessary changes to preexisting files have been reverted

DivakarUngatla commented 4 years ago

Hi @jakeleveroni Jacob,

Looks like you have duplicated generic property files like AiProperties , BentenProxyConfig.java etc.. in the hacker rank bolt that you created (this is not necessary, you should only have HackerNewsProperties. java in you hacker rank bolt). And all references to these property files have changed to the property files in hackerbolt (this could have happened because of an IDE auto import).

I would recommend create a new branch from master in your for and then use git cherrypick to transfer only necessary commits from the current branch to new branch and raise a PR from the new branch.