search

intuit / devtools-ds

UI components, libraries, and templates for building robust devtools experiences.
https://intuit.github.io/devtools-ds
MIT License
250 stars 15 forks source link

Fix: Make Components Work with SSR #18

Closed hipstersmoothie closed 3 years ago

hipstersmoothie commented 3 years ago

What Changed

be better about using window

Why

needed for server rendering

What might be impacted

🤷‍♂️

📦 Published PR as canary version: 1.0.4-canary.18.394.0
:sparkles: Test out this PR locally via: ```bash npm install @devtools-ds/console@1.0.4-canary.18.394.0 npm install @devtools-ds/dom-inspector@1.0.4-canary.18.394.0 npm install @devtools-ds/diagnostic@1.0.4-canary.18.394.0 npm install @devtools-ds/icon@1.0.4-canary.18.394.0 npm install @devtools-ds/navigation@1.0.4-canary.18.394.0 npm install @devtools-ds/node@1.0.4-canary.18.394.0 npm install @devtools-ds/object-inspector@1.0.4-canary.18.394.0 npm install @devtools-ds/table@1.0.4-canary.18.394.0 npm install @devtools-ds/tree@1.0.4-canary.18.394.0 npm install @devtools-ds/create@1.0.4-canary.18.394.0 npm install @devtools-ds/docs@1.0.4-canary.18.394.0 npm install @devtools-ds/object-parser@1.0.4-canary.18.394.0 npm install @devtools-ds/port-controller@1.0.4-canary.18.394.0 npm install @devtools-ds/storybook-theme-addon@1.0.4-canary.18.394.0 npm install @devtools-ds/storybook-utils@1.0.4-canary.18.394.0 npm install @devtools-ds/themes@1.0.4-canary.18.394.0 # or yarn add @devtools-ds/console@1.0.4-canary.18.394.0 yarn add @devtools-ds/dom-inspector@1.0.4-canary.18.394.0 yarn add @devtools-ds/diagnostic@1.0.4-canary.18.394.0 yarn add @devtools-ds/icon@1.0.4-canary.18.394.0 yarn add @devtools-ds/navigation@1.0.4-canary.18.394.0 yarn add @devtools-ds/node@1.0.4-canary.18.394.0 yarn add @devtools-ds/object-inspector@1.0.4-canary.18.394.0 yarn add @devtools-ds/table@1.0.4-canary.18.394.0 yarn add @devtools-ds/tree@1.0.4-canary.18.394.0 yarn add @devtools-ds/create@1.0.4-canary.18.394.0 yarn add @devtools-ds/docs@1.0.4-canary.18.394.0 yarn add @devtools-ds/object-parser@1.0.4-canary.18.394.0 yarn add @devtools-ds/port-controller@1.0.4-canary.18.394.0 yarn add @devtools-ds/storybook-theme-addon@1.0.4-canary.18.394.0 yarn add @devtools-ds/storybook-utils@1.0.4-canary.18.394.0 yarn add @devtools-ds/themes@1.0.4-canary.18.394.0 ```
tylerkrupicka commented 3 years ago

Bundle Size Report

name master pr +/- %
@devtools-ds/themes 6.01 kB 6.10 kB 91.00 Bytes 2%
@devtools-ds/table 23.89 kB 22.97 kB -921.00 Bytes -4%
Total 29.90 kB 29.07 kB -830.00 Bytes -3%

✅ No size breaking changes detected

Courtesy of your bundle-size bot :package::rocket:

tylerkrupicka commented 3 years ago

Build Info

Your PR was successfully deployed by CircleCI #393

Storybook

tylerkrupicka commented 3 years ago

:rocket: PR was released in v1.0.4 :rocket: