search

intuit / devtools-ds

UI components, libraries, and templates for building robust devtools experiences.
https://intuit.github.io/devtools-ds
MIT License
250 stars 15 forks source link

feat(table): sticky header #22

Closed mormubis closed 2 years ago

mormubis commented 2 years ago

What Changed

Now the table has a sticky header. It will behave as you expect, sticking to the top when needed.

Why

The content of the table could be longer than expected, as a sequence of logs.

Screen Shot 2022-04-07 at 9 09 07 PM

What might be impacted

Styles could be broken for some browsers.

Firefox & Chrome support sticky headers.

Todo:

mormubis commented 2 years ago

Hey @tylerkrupicka / @adierkens, tagging you as I don't know the process to contribute to the project. Do I need to generate any artifacts? I've seen other PRs automatically generate storybook previews. How can I trigger that job here?

Thank you for this fantastic work!

mormubis commented 2 years ago

Hey @tylerkrupicka / @adierkens, tagging you as I don't know the process to contribute to the project. Do I need to generate any artifacts? I've seen other PRs automatically generate storybook previews. How can I trigger that job here?

Thank you for this fantastic work!

Hey @tylerkrupicka @adierkens, another bump. I hope this time I am more successful.

tylerkrupicka commented 2 years ago

Hey @mormubis, thanks for the contribution and sorry for the delay responding! Something looks broken with the CircleCI build for tests, so I'm taking a look at that to get your change in.

tylerkrupicka commented 2 years ago

:rocket: PR was released in v1.2.0 :rocket:

tylerkrupicka commented 2 years ago

@mormubis thank you for your contribution! I made some fixes to the CSS and height detection, and released this feature in https://github.com/intuit/devtools-ds/releases/tag/v1.2.0.