search

intuit / fuzzy-matcher

A Java library to determine probability of objects being similar.
Apache License 2.0
228 stars 69 forks source link

Element constructor does not initialize the scoringFunction with the value passed to the constructor signature #19

Closed ssfernando closed 4 years ago

ssfernando commented 4 years ago

Line 63 of Element class is assigning the this.scoringFunction to itself when the scoringFunction passed through the constructor is different of null.

https://github.com/intuit/fuzzy-matcher/blob/81d5113a43db24e690a65e0f2437124693a12ff4/src/main/java/com/intuit/fuzzymatcher/domain/Element.java#L63

manishobhatia commented 4 years ago

Thanks for reporting this issue. We have a pull https://github.com/intuit/fuzzy-matcher/pull/20 to fix this. Will include it in our next release

ssfernando commented 4 years ago

Thank you!

manishobhatia commented 4 years ago

Closing issue, fix has been released with 0.4.4 version