intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
120 stars 154 forks source link

[typescript][enhancement]: Update typescript definitions to match the latest SDK v3.0.2 #100

Open abisalehalliprasan opened 3 years ago

abisalehalliprasan commented 3 years ago

Hacktoberfest is underway right now and we would love for you to contribute 🚀 . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Update typescript definitions file to match the latest SDK v3.0.2 Ref : index.d.ts file

Fix Needed

Add the missing API typings ( interfaces/classes ) into the definition file ( index.d.ts )

You can compare using the latest SDK version v3.0.2

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

shlok-kothari commented 3 years ago

Hi @abisalehalliprasan I would like to take a shot at this

abisalehalliprasan commented 3 years ago

@shlok-kothari : Awesome. Go for it. 👍

barakplasma commented 2 years ago

since this was merged, I suggest closing this issue. By the way, since release 4.0 happened, have the typescript definitions been updated since then? @abisalehalliprasan