intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
120 stars 154 forks source link

[typescript][enhancement]: Remove OAuth1 typing definitions from index.d.ts #101

Closed abisalehalliprasan closed 3 years ago

abisalehalliprasan commented 3 years ago

Hacktoberfest is underway right now and we would love for you to contribute 🚀 . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Remove unwanted OAuth1 typing definitions from index.d.ts file

Fix Needed

Remove all the unnecessary typings : ( interface )

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

luisgregson commented 3 years ago

Hey, i've some experience with type definitions and would like to give this issue a go. Can it be assigned to me please?

pradeepb2505 commented 3 years ago

104 Created a PR for this issue a few days back. Please do review it. Thanks.