intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
120 stars 154 forks source link

[typescript][enhancement]: Write a unit test to validate typings definition file #102

Closed abisalehalliprasan closed 3 years ago

abisalehalliprasan commented 3 years ago

Hacktoberfest is underway right now and we would love for you to contribute πŸš€ . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Write a unit test to validate the typings definition file ex: types.test.ts

typings defintion file : index.d.ts file

Fix Needed

Provide a bare minimum test for the typings definition file mentioned above.

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

VeenaDesai38 commented 3 years ago

@abisalehalliprasan I would like to take this up.

VeenaDesai38 commented 3 years ago

@abisalehalliprasan PR raised for the same https://github.com/intuit/oauth-jsclient/pull/105

abisalehalliprasan commented 3 years ago

Thanks @VeenaDesai38 for the contribution πŸš€ . Will review the PR soon.

VeenaDesai38 commented 3 years ago

@abisalehalliprasan Can you please take a look at this PR?