Open abisalehalliprasan opened 3 years ago
@abisalehalliprasan I am picking this up now.
@nsinghal12 : Awesome. Thanks π
@abisalehalliprasan I am a beginner can you guide me to fix this issue and can I work on this issue?
any updates? is the issue open?
Hacktoberfest is underway right now and we would love for you to contribute π . More information on #hacktoberfest is here
Develop-with-Intuit for Hacktoberfest
Problem
SDK should support passing the state parameter. Provide a fix to support this in the typings definitions:
index.d.ts
fileThe expected type comes from property 'state' which is declared here on type
AuthorizeParams
const authUri = oauthClient.authorizeUri({scope:[OAuthClient.scopes.Accounting,OAuthClient.scopes.OpenId],state:'testState'});
Errors dissapears if you let SDK provide a csrf using the moule :
const authUri = oauthClient.authorizeUri({scope:[OAuthClient.scopes.Accounting,OAuthClient.scopes.OpenId]});
Fix Needed
The SDK typings definition file should allow custom state parameters ( string ) to be passed.
Instructions to use the sample app
In order to test the typings locally from the sample project, you'll need to link the
intuit-oauth
package with yarn or npm.PR Guidelines
Kindly follow the below instructions to submit your PR :
typescript
branch).npm install
for dependencies.npm test
to execute all specs.Once ready, please submit a PR to the
typescript
branch here.Note :
PR's will be merged to themaster
branch once all the testing is completed.