intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
120 stars 154 forks source link

[Issue102][Hacktoberfest] unit test to validate typings definition file #105

Closed VeenaDesai38 closed 3 years ago

VeenaDesai38 commented 3 years ago

Enum, Interface, Class defined in index.d.ts are the implementation details. Unit tests that validate the behavior of the enums already exists in test module. The changes in types.test.ts are only meant to test the types and whether the mandatory fields are returned or not. Not the actual value returned by the fields. This file doesn't add to the coverage as nothing is executable.

Screen Shot 2020-10-22 at 2 35 32 AM
VeenaDesai38 commented 3 years ago

@abisalehalliprasan Please review this PR.

abisalehalliprasan commented 3 years ago

Thanks @VeenaDesai38 for the contribution 🚀