search

intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
120 stars 154 forks source link

Update typescript definitions to match the latest SDK v3.0.2 #106

Closed shlok-kothari closed 3 years ago

shlok-kothari commented 3 years ago

https://github.com/intuit/oauth-jsclient/issues/100

shlok-kothari commented 3 years ago
Screen Shot 2020-10-25 at 10 27 23 PM

I'm unable to run the sample app, for some reason req.query.json.clientId is not being treated as a property of a JSON object, though I did verify that typeof(req.query.json) is object. I tried JSON.parse(req.query.json.toString()).clientId but that gives me a different error: SyntaxError: Unexpected token o in JSON at position 1

@abisalehalliprasan I had a couple of questions, this is my first time working with typescript so I'm sorry if it was something obvious!

abisalehalliprasan commented 3 years ago

Thanks @shlok-kothari. I will take a look at the PR 👍