search

intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
123 stars 159 forks source link

Dependency is causing compile errors #143

Closed alanhett closed 6 months ago

alanhett commented 1 year ago

Thank you for providing this JS SDK.

The dependency make-error-cause has a section in it where a function name is redeclared as a variable:

function makeErrorCause(value, _super) {
    if (_super === void 0) { _super = makeErrorCause.BaseError; }
    return makeError(value, _super);
}
var makeErrorCause;

This causes compilers like SWC to throw an error because this is technically not allowed in JS modules.

make-error-cause is a dependency of the popsicle http library but both seem like they could be removed and replaced with the native fetch library, eliminating several dependencies, or by using a different HTTP library such as axios.

pragati0909 commented 11 months ago

I would like to work on this issue, @alanhett & @rajeshgupta723 .

rajeshgupta723 commented 11 months ago

I would like to work on this issue, @alanhett & @rajeshgupta723 .

@pragati0909 please go ahead and feel free to raise your PR changes to merge into the developer branch

arepp23 commented 7 months ago

Still seeing this issue. Any update?

rajeshgupta723 commented 6 months ago

As release 4.1.0 was completed, closing this issue