intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
121 stars 156 forks source link

Adds typings #37

Closed efredin closed 4 years ago

efredin commented 4 years ago

Adds typescript support. Re-opened targeting new typescript branch on request of @abisalehalliprasan

In order to avoid adding external typing dependencies, I've left log() typings fairly generic. There is an @types/winston package available, but its probably not necessary.

abisalehalliprasan commented 4 years ago

Thanks @efredin will test it and get back to you

efredin commented 4 years ago

Anything I can contribute to help validate the typings?

abisalehalliprasan commented 4 years ago

@efredin : Thanks for checking with us. I am not too familiar with typescript, so would be helpful if you could show me how to use index.d.ts in the sample

I will be merging this PR into typescript branch and create a new issue for the sample. Does that work with you?

efredin commented 4 years ago

@abisalehalliprasan That works for me. I should be able to put some time to this next week.

The typings won't impact any javascript consumers. I can update the sample in that branch to a typescript project and run it through the typescript compiler to demonstrate things are working as expected.

abisalehalliprasan commented 4 years ago

@efredin : Awesome thanks

abisalehalliprasan commented 4 years ago

🚀 PR was released in branch typescript for hacktoberfest