search

intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
121 stars 156 forks source link

Fix/eslint formatting #38

Closed mcrosby114 closed 4 years ago

mcrosby114 commented 4 years ago

Addresses the all the eslint errors except the "no-undef" from #32.

mcrosby114 commented 4 years ago

@abisalehalliprasan can we upgrade the version of node to something greater than 6, like version 8? Seeing there's an issue with the JS engine not recognizing Object.entries() (https://travis-ci.org/intuit/oauth-jsclient/jobs/593613545#L292).

This shows how it's incompatible with the current version of node: https://node.green/#ES2017-features-Object-static-methods-Object-entries

abisalehalliprasan commented 4 years ago

@abisalehalliprasan can we upgrade the version of node to something greater than 6, like version 8? Seeing there's an issue with the JS engine not recognizing Object.entries() (https://travis-ci.org/intuit/oauth-jsclient/jobs/593613545#L292).

This shows how it's incompatible with the current version of node: https://node.green/#ES2017-features-Object-static-methods-Object-entries

Yeah, I think it should be fine. I can bump a version up and release, following the sem version.

Looks Good @mcrosby114 👍 🙌

abisalehalliprasan commented 4 years ago

🚀 PR was released in v2.0.0 hacktoberfest

mcrosby114 commented 4 years ago

https://github.com/intuit/oauth-jsclient/pull/38#issuecomment-543935872 🙌