search

intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID
https://developer.intuit.com/
Apache License 2.0
121 stars 156 forks source link

ngrok current version doesn't work #41

Closed BrandonCopley closed 4 years ago

BrandonCopley commented 4 years ago

Ngrok is currently tied to version ^2.2.9 but it really should be 3.2.3 Currently version 2.2.9 does NOT work and the error: Error: ngrok is not yet ready to start tunnels is displayed

petmat commented 4 years ago

I'll fix this!

BrandonCopley commented 4 years ago

It may need an api example update as well since ngrok uses promises now.

On Wed, Oct 9, 2019 at 6:54 AM Matti Petrelius notifications@github.com wrote:

I'll fix this!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/intuit/oauth-jsclient/issues/41?email_source=notifications&email_token=AAJFFBRF5SJ2U72442CSOT3QNXA6DA5CNFSM4I6Y3MZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAXUALI#issuecomment-539967533, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFFBQVWGDN3M7RLACZBXTQNXA6DANCNFSM4I6Y3MZA .

-- -- [image: Giftnix]

Brandon Copley

Founder & CEO

t: 512.784.6060 <(512)%20784-6060>

e: copley.brandon@gmail.com

abisalehalliprasan commented 4 years ago

@petmat : Thanks for the PR #45 . Did you get a chance to test the sample app with the new ngrok version?

petmat commented 4 years ago

It turned out that I tested it but not properly. Connecting to Ngrok worked but it was not handled properly since the 3.2.5 version uses promises instead of callbacks. I changed the handling of the connect call to promises and it prints out the correct info in the terminal. I also tested the whole sample app and managed to send a request to the API and get a response back.

abisalehalliprasan commented 4 years ago

Thanks @petmat