intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID

https://developer.intuit.com/

Apache License 2.0

121 stars 156 forks source link

Add more code coverage for OAuthClient #54

Closed oscargrp closed 4 years ago

oscargrp commented 4 years ago

Improved test code coverage

Changes

Updated OAuthClientTest include a test case for makeApiCall with parameters, and updated test for generateOauth1Sign to be more precise.

Screen Shot 2019-10-18 at 11 48 30 AM

Notes

I have another set of changes coming with more coverage for OAuthClientTest that I will push in another PR.

coveralls commented 4 years ago

Coverage increased (+0.8%) to 88.063% when pulling e4a1c2ff63dfb635746f0a2edb6a203650fd548a on oscargrp:add_more_code_coverage into 73aa0dd7375fb8c12b5293b4ed434b49f700af38 on intuit:develop.

coveralls commented 4 years ago

Coverage increased (+0.8%) to 88.063% when pulling e4a1c2ff63dfb635746f0a2edb6a203650fd548a on oscargrp:add_more_code_coverage into 73aa0dd7375fb8c12b5293b4ed434b49f700af38 on intuit:develop.

abisalehalliprasan commented 4 years ago

@oscargrp: Thanks

abisalehalliprasan commented 4 years ago

🚀 PR was released in v2.0.0 hacktoberfest