Fix: ValidateIdToken method and unit tests

intuit / oauth-jsclient

Intuit's NodeJS OAuth client provides a set of methods to make it easier to work with OAuth2.0 and Open ID

https://developer.intuit.com/

Apache License 2.0

121 stars 156 forks source link

Fix: ValidateIdToken method and unit tests #58

Closed heykevin closed 4 years ago

heykevin commented 4 years ago

I was attempting to increase code coverage of the validateIdToken test when I realized the tests were not working as expected which then led me to realizing the method itself was not working as expected.

Changes:

Cast response status to number similar to AuthResponse
Check clientID in the list of audience, it was comparing ID to an array before
mockIdPayload in the tests that matches what we are expecting in tests

coveralls commented 4 years ago

Coverage increased (+3.3%) to 91.389% when pulling 4ca5afca969ecab768565f8970d7b06bed6489f5 on heykevin:broken_validateIdToken into 6352c7589fef9d94aa0c4ca5b9b04c21b2066675 on intuit:develop.

coveralls commented 4 years ago

Coverage increased (+3.3%) to 91.389% when pulling 4ca5afca969ecab768565f8970d7b06bed6489f5 on heykevin:broken_validateIdToken into 6352c7589fef9d94aa0c4ca5b9b04c21b2066675 on intuit:develop.

abisalehalliprasan commented 4 years ago

Thanks @heykevin for the changes. Good catch 👍